moving tabify to data.search #57453
moving tabify to data.search #57453
Conversation
ppisljar
added
v8.0.0
Team:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
| import { tabifyGetColumns } from '../_get_columns'; | ||
| import { Vis } from '../../../../../core_plugins/visualizations/public'; | ||
| import FixturesStubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern'; | ||
| import stubbedLogstashIndexPatternService from '../../../../../../fixtures/stubbed_logstash_index_pattern'; |
There was a problem hiding this comment.
Would you mind dropping the __tests__ folder, if we're at it?
| @@ -20,3 +20,5 @@ | |||
| export * from './aggs'; | |||
| export { getRequestInspectorStats, getResponseInspectorStats } from './utils'; | |||
| export { serializeAggConfig } from './expressions/utils'; | |||
| // @ts-ignore | |||
| export { tabifyAggResponse, tabifyGetColumns } from '../../common/tabify'; | |||
There was a problem hiding this comment.
Any consumer within the plugin can import from common and externally, it will be imported from the index.ts file
So I don't think we really need to re-export this.
|
|
||
| return columns; | ||
| } | ||
| export { tabifyGetColumns } from '../../../../core_plugins/data/public'; |
There was a problem hiding this comment.
Can we get rid this of this file all together and use this import from src/legacy/ui/public/agg_response/index.js?
This will not require changes in multiple places.
Same goes for src/legacy/ui/public/agg_response/tabify/tabify.ts
| @@ -81,4 +81,7 @@ export { | |||
| // search_source | |||
| getRequestInspectorStats, | |||
| getResponseInspectorStats, | |||
| // tabify | |||
There was a problem hiding this comment.
Also, if we're at it. what is tabify?
As this is pretty old code, would you mind adding a couple of sentences on what it is used for?
|
This PR is a part of #57660. |
Summary
moving tabify to data.search
Checklist
Delete any items that are not applicable to this PR.
For maintainers